fix: clean up public API for clearing files #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
force-pushed
the
clear-api-cleanup
branch
2 times, most recently
from
91c7ffc to
a51b842
Compare
`clear_layer_data()` and `clear_caches` are never called within `rust-fil-proofs` and also not used in `rust-filecoin-proofs-api`, hence remove them. The `clear_cache()` and `clear_synthetic_proofs()` functions don't need to be generic over the tree as it's never used within those functions. This is a breaking change. BREAKING CHANGE: signature of `clear_cache()` and `clear_synthetic_proofs()` changed. The generic parameter is no longer needed.
vmx
force-pushed
the
clear-api-cleanup
branch
from
a51b842 to
d64fcfe
Compare
cryptonemo
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clear_layer_data()andclear_cachesare never called withinrust-fil-proofsand also not used inrust-filecoin-proofs-api, hence remove them.The
clear_cache()andclear_synthetic_proofs()functions don't need to be generic over the tree as it's never used within those functions. This is a breaking change.BREAKING CHANGE: signature of
clear_cache()andclear_synthetic_proofs()changed. The generic parameter is no longer needed.I've put this on master. I'll rebase it, once master is green.