feat: measure fuel usage and timing stats #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rude to remove me as an author @Kubuxu 🙃🤣 |
|
It wasn't on purpose 🙃 no idea why it picked up steb instead of you as the author. |
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
feat: expose machine from executor via deref
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
fvm: more stats
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
feat: track "real" compute gas
feat: time module compile/link/instantiate time
detailed gas and fuel tracing: initial implementation.
Introduces a new Cargo feature `tracing` that enables detailed gas tracing.
Traces are accumulated in the GasTracer, owned by the CallManager.
Gas traces specify the context, point of tracing, consumption stats, and timing stats.
We currently support these tracing points:
- {Pre,Post}Syscall
- {Pre,Post}Extern
- {Enter,Exit}Call
- Start (of the call stack)
- Finish (of the call stack)
Traces are currently serialized to JSON and printed directly on stdout.
There's a bit of duplication the syscall binding macros that I'm not happy about, and
perhaps we could make the tracepoints in the CallManager a bit DRYer.
fix build.
Trace to file
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
force-pushed
the
kub/detailed-gas-tracing
branch
from
99d919c to
98b5623
Compare
|
Fixed |
raulk
reviewed
Apr 23, 2022
There was a problem hiding this comment.
This tracing framework is useful to inspect running logic in detail, how it interacts with the environment, debugging execution flow, understand the instruction complexity of ranges, and get a relative sense of where time is spent.
However, this should come with a massive warning sign: the timing numbers are considerably skewed by several factors:
- Non-negligible overhead of getting time from the system.
- According to minstant benchmarks,
std::time::Instant::now()can have an overhead of as much as 30ns on the specified platform. - Using the TSC is a solution, but even with minstant there's an overhead of 10ns which needs to be accounted for.
- Potential solution: correct for overhead by benchmarking getting time, and applying a negative offset to all duration readings.
- According to minstant benchmarks,
- Additional instructions + cache thrashing due to the tracing logic, which is not observed in real executions.
raulk
force-pushed
the
kub/detailed-gas-tracing
branch
from
c667a48 to
7343111
Compare
raulk
force-pushed
the
kub/detailed-gas-tracing
branch
from
7343111 to
7730a4c
Compare
raulk
force-pushed
the
kub/detailed-gas-tracing
branch
2 times, most recently
from
d953e55 to
22edabc
Compare
raulk
force-pushed
the
kub/detailed-gas-tracing
branch
2 times, most recently
from
f9d5ea2 to
8ea11f0
Compare
raulk
force-pushed
the
kub/detailed-gas-tracing
branch
from
8ea11f0 to
a5d4a38
Compare
raulk
force-pushed
the
kub/detailed-gas-tracing
branch
from
80c782e to
588abec
Compare
|
We will close this PR for now, but will keep the branch around as a reference for WASM-development in the FVM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.