Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cli: list claims and remove expired claims #9875

Merged
merged 2 commits into from
Jan 12, 2023
Merged

feat: cli: list claims and remove expired claims #9875

merged 2 commits into from
Jan 12, 2023

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Dec 14, 2022 •
edited
Loading

Related Issues

Closes #9271

Proposed Changes

Adds a cli command to list all claims for a given provider.
Adds a cli command to remove expired claims for a given provider.

Sample Output

Screenshot 2023-01-12 at 12 43 23 PM

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner December 14, 2022 21:56
@geoff-vball geoff-vball force-pushed the gstuart/remove-expired-claim branch 3 times, most recently from b2d0a4a to 362c3a6 Compare December 15, 2022 00:35
@geoff-vball geoff-vball force-pushed the gstuart/remove-expired-claim branch from 362c3a6 to 6ca975e Compare December 15, 2022 06:07
arajasek
arajasek approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fill in the PR description, including sample output of the list command?

cli/filplus.go Show resolved Hide resolved
cli/filplus.go Show resolved Hide resolved
@geoff-vball geoff-vball merged commit 923d412 into master Jan 12, 2023
@geoff-vball geoff-vball deleted the gstuart/remove-expired-claim branch January 12, 2023 17:44
@geoff-vball geoff-vball mentioned this pull request Jan 20, 2023
Closed
7 tasks
@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Network v18
Development

Successfully merging this pull request may close these issues.

Add cli to remove expired claims
3 participants
@geoff-vball @arajasek @jennijuju