Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lotus-bench make command #8751

Merged
merged 1 commit into from
May 30, 2022
Merged

fix: lotus-bench make command #8751

merged 1 commit into from
May 30, 2022

Conversation

sunday527
Copy link
Contributor

@sunday527 sunday527 requested a review from a team as a code owner May 30, 2022 11:36
magik6k
magik6k approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I don't think this changes anything other than the version string, and we will soon move to single binary for multiple networks, but for now this is slightly more correct.

@magik6k magik6k merged commit 041af45 into filecoin-project:feat/nv16 May 30, 2022
@magik6k magik6k mentioned this pull request May 30, 2022
Closed
@ghost ghost mentioned this pull request Jan 21, 2024
Closed
@NateWebb03 NateWebb03 mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunday527 @magik6k