Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show prepared tasks in sealing jobs #7527

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 15, 2021

Currently tasks which are between the preparing and running states will disappear from lotus-miner sealing jobs output. This PR fixes that

TODO:

  • Test that it actually works
  • Fix prepared work starting too early

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #7527 (e508055) into master (98ff1c4) will decrease coverage by 0.08%.
The diff coverage is 67.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7527      +/-   ##
==========================================
- Coverage   39.96%   39.88%   -0.09%     
==========================================
  Files         632      632              
  Lines       66926    66970      +44     
==========================================
- Hits        26750    26713      -37     
- Misses      35560    35633      +73     
- Partials     4616     4624       +8     
Impacted Files Coverage Δ
cmd/lotus-miner/sealing.go 41.52% <0.00%> (-0.50%) ⬇️
extern/sector-storage/storiface/worker.go 53.84% <ø> (ø)
extern/sector-storage/stats.go 58.06% <33.33%> (-2.29%) ⬇️
extern/sector-storage/worker_tracked.go 76.53% <65.57%> (-13.62%) ⬇️
extern/sector-storage/sched.go 83.95% <100.00%> (-0.77%) ⬇️
extern/sector-storage/sched_worker.go 79.65% <100.00%> (+1.20%) ⬆️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98ff1c4...e508055. Read the comment docs.

@magik6k magik6k force-pushed the feat/show-prepared-waitres branch from dfa7959 to 3aa385e Compare October 18, 2021 14:58
@magik6k magik6k force-pushed the feat/show-prepared-waitres branch from 3aa385e to 70589e4 Compare October 18, 2021 16:45
@magik6k magik6k marked this pull request as ready for review October 19, 2021 17:58
@magik6k magik6k requested a review from a team as a code owner October 19, 2021 17:58
@magik6k magik6k merged commit f7884c4 into master Oct 20, 2021
@magik6k magik6k deleted the feat/show-prepared-waitres branch October 20, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants