fix: support node instantiation in external packages #7511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement ChainGetPath on ChainModuleAPI
Codecov Report
@@ Coverage Diff @@
## master #7511 +/- ##
==========================================
+ Coverage 39.31% 39.32% +0.01%
==========================================
Files 627 627
Lines 66373 66379 +6
==========================================
+ Hits 26092 26105 +13
+ Misses 35763 35759 -4
+ Partials 4518 4515 -3
Continue to review full report at Codecov.
|
magik6k
approved these changes
Oct 13, 2021
frrist
commented
Oct 13, 2021
Comment on lines
+377
to
+383
| func WithEnableLibp2pNode(enable bool) func(s *Settings) error { | ||
| return func(s *Settings) error { | ||
| s.enableLibp2pNode = enable | ||
| return nil | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
frrist
commented
Oct 13, 2021
| @@ -105,6 +106,10 @@ func (m *ChainModule) ChainGetTipSet(ctx context.Context, key types.TipSetKey) ( | |||
| return m.Chain.LoadTipSet(key) | |||
| } | |||
|
|
|||
| func (m *ChainModule) ChainGetPath(ctx context.Context, from, to types.TipSetKey) ([]*api.HeadChange, error) { | |||
There was a problem hiding this comment.
change allows ChainModuleAPI to satisfy the EventsAPI interface: https://github.com/filecoin-project/lily/pull/745/files#diff-a2a1458325b025a5434765ff39f72c2a2035ef2efdb9aacfaddad32505945088L22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these changes lily is unable to use lotus as a library to instantiate a node.
If this could make it into the coming 1.13 release that would be 👌