Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline codegen #7495

Merged
merged 8 commits into from
Oct 19, 2021
Merged

Inline codegen #7495

merged 8 commits into from
Oct 19, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 11, 2021

The general idea is that we can use some magic template comments + shared json to add codegen to any part of the code.

TODO:

  • Decide if we want this
  • Maybe figure out a nicer comment format
  • Add to some more places
  • Attach to make gen
  • Fix lint

To use right now, run go run ./gen/inline-gen . gen/inlinegen-data.json; go fmt ./...

@arajasek
Copy link
Contributor

I think we want this!

@magik6k magik6k force-pushed the feat/inline-codegen branch from b945672 to 3943c3a Compare October 18, 2021 15:54
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #7495 (1d8a9c7) into master (67bdc26) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7495      +/-   ##
==========================================
- Coverage   39.88%   39.70%   -0.19%     
==========================================
  Files         631      631              
  Lines       66907    66924      +17     
==========================================
- Hits        26688    26574     -114     
- Misses      35614    35746     +132     
+ Partials     4605     4604       -1     
Impacted Files Coverage Δ
build/params_shared_vals.go 71.42% <ø> (ø)
chain/actors/version.go 87.50% <ø> (ø)
chain/vm/mkactor.go 50.00% <ø> (ø)
chain/consensus/filcns/compute_state.go 74.11% <100.00%> (+0.78%) ⬆️
chain/state/statetree.go 67.55% <100.00%> (+0.09%) ⬆️
itests/kit/ensemble_opts_nv.go 100.00% <100.00%> (ø)
chain/actors/builtin/paych/v5.go 0.00% <0.00%> (-40.00%) ⬇️
chain/actors/builtin/paych/message5.go 0.00% <0.00%> (-28.89%) ⬇️
extern/sector-storage/sched_resources.go 73.52% <0.00%> (-11.77%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bdc26...1d8a9c7. Read the comment docs.

@magik6k magik6k marked this pull request as ready for review October 18, 2021 16:06
@magik6k magik6k requested a review from a team as a code owner October 18, 2021 16:06
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiice

@magik6k magik6k enabled auto-merge October 19, 2021 09:05
@magik6k magik6k merged commit d910098 into master Oct 19, 2021
@magik6k magik6k deleted the feat/inline-codegen branch October 19, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants