Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop adding Jennifer's $HOME to lotus docs #7477

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

ribasushi
Copy link
Collaborator

No description provided.

@ribasushi ribasushi requested a review from jennijuju October 8, 2021 08:16
@ribasushi ribasushi requested a review from a team as a code owner October 8, 2021 08:16
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #7477 (cb39dd8) into master (734a03c) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7477      +/-   ##
==========================================
- Coverage   39.24%   39.15%   -0.09%     
==========================================
  Files         631      631              
  Lines       66853    66853              
==========================================
- Hits        26235    26176      -59     
- Misses      36049    36094      +45     
- Partials     4569     4583      +14     
Impacted Files Coverage Δ
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
storage/wdpost_sched.go 75.24% <0.00%> (-5.95%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
chain/actors/builtin/paych/paych.go 14.77% <0.00%> (-4.55%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734a03c...cb39dd8. Read the comment docs.

@magik6k magik6k merged commit df2a852 into master Oct 11, 2021
@magik6k magik6k deleted the chore/fix-docsgen-cli-envvar-polution branch October 11, 2021 12:24
@jennijuju
Copy link
Member

I mean… we could’ve updated the pr title before merging 😂😂😂

@ribasushi
Copy link
Collaborator Author

NEVER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants