Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpool: fix: data race when adding messages #10758

Closed
wants to merge 3 commits into from

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Apr 25, 2023

Related Issues

#10755

Proposed Changes

Remove cache hacks and change actor look up from GetActorAfter to GetActorBefore

Additional Info

This drop support for sending messages from an account immediately after creating it

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snissn snissn requested a review from a team as a code owner April 25, 2023 20:40
@snissn snissn linked an issue Apr 25, 2023 that may be closed by this pull request
@Stebalien Stebalien requested review from magik6k and arajasek April 25, 2023 20:48
@Stebalien
Copy link
Member

Ok, so, I was wrong. checkBalance calls GetActorAfter (through getStateBalance) as well so warming the cache is still effective. We could try to switch that check to GetActorBefore as well, but I'm even less sure of the potential downsides...

@snissn
Copy link
Contributor Author

snissn commented Apr 27, 2023

Closing this PR for new PR: #10771

I added RLocks around the getStateNonce call in the new PR

@snissn snissn closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mpool] data race when adding messages
2 participants