Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: EthAPI: Drop unnecessary param from newEthTxReceipt #10411

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Mar 7, 2023

Related Issues

The Message Lookup isn't needed for this method.

Proposed Changes

Drop it. Strict simplification.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner March 7, 2023 18:41
@arajasek arajasek requested review from ychiaoli18 and raulk March 7, 2023 18:41
@arajasek arajasek added this to the EthAPI refinements milestone Mar 8, 2023
@arajasek arajasek merged commit 9fa8167 into master Mar 9, 2023
@arajasek arajasek deleted the asr/simplity-new-eth-tx-rct branch March 9, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants