Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shed: Add a tool to read data from sectors #10169

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Feb 1, 2023

Related Issues

Proposed Changes

Adds a tool to extract data from sectors from a running lotus-miner deployment. This connects to the storage subsystem much like boost would for retrievals and reads raw pieces.

Additional Info

I wanted to debug why some of my deals failed to get indexed by dagstore, but extracting data from sectors was not easy, so I built this tool.

Apparently my deal was all null bytes somehow
2023-02-01-174917_1062x1085_scrot

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner February 1, 2023 16:54
}

func (e *emptyLocalStorage) Stat(path string) (fsutil.FsStat, error) {
//TODO implement me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What needs implementing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this is just a dummy impl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment then?

Copy link
Contributor

@shrenujbansal shrenujbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a high level. Just had a few additional qs

@magik6k magik6k force-pushed the feat/shed-read-sector branch from c253839 to 12656b0 Compare February 16, 2023 15:47
@magik6k magik6k enabled auto-merge February 16, 2023 15:47
@magik6k magik6k merged commit 8f1c232 into master Feb 16, 2023
@magik6k magik6k deleted the feat/shed-read-sector branch February 16, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants