fix: rpcenc: Don't hang when source dies #10116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
fix/rpcenc-hang
branch
from
c7bad69 to
128bdc6
Compare
| return | ||
| } | ||
| } | ||
| }() |
There was a problem hiding this comment.
What does this extra closed channel do when we are immediately closing it? Isn't this going to race between the two select cases and possibly immediately returning without reading anything off of wr.res?
There was a problem hiding this comment.
It cleans up this goroutine.
wr.res can only be written in wr.beginOnce, and is only written to once, so by calling it below, we know that wr.res must have been written to already.
This bit of code spins up a go-routine which will read pending sends into wr.res, then will make sure that wr.beginOnce was done (so wr.res can't be written to anymore), then it will shutdown the draining goroutine by closing the closed channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Couldn't find anything about "AddPiece stuck" where it wasn't showing up in either
sealig sched-diagorsealing jobs, but maybe there is an issue about thatFixes #10115
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps