fix: itests: Fix flaky paych test #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arajasek
approved these changes
Jan 23, 2023
| head, err := paymentReceiver.ChainHead(ctx) | ||
| require.NoError(t, err) | ||
|
|
||
| paymentReceiver.WaitTillChain(ctx, kit.HeightAtLeast(head.Height())) |
There was a problem hiding this comment.
I'd even suggest doing head + 5 here, just in case of minor reorgs.
There was a problem hiding this comment.
There's one miner in that test, can't have reorgs
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Did we really not have an issue for this?
Proposed Changes
Fix the test
Additional Info
The test was failing likely due to it running on two nodes, and in some cases when a message creating a channel landed on one node, we'd query state from the other node - which isn't the block miner, and could fall behind in sync (block time was 5ms, so that could happen quite easily). The fix is to wait for the nodes to be in sync at certain points.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps