fix: ci: Properly balance <<?>> in circleci docker config #10088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlacierWalrus
approved these changes
Jan 20, 2023
geoff-vball
approved these changes
Jan 20, 2023
7 tasks
geoff-vball
changed the title
geoff-vball
reviewed
Jan 21, 2023
| docker push filecoin/<<parameters.image>>:<<parameters.channel>>-<<parameters.network>> | ||
| docker push filecoin/<<parameters.image>>:<<parameters.channel>> |
There was a problem hiding this comment.
I think this broke stuff?
There was a problem hiding this comment.
Ah, shoot. I did! Not sure how that change snuck in there, I only meant to do the other two. I'll open a new PR now.
There was a problem hiding this comment.
ianconsolata
added a commit
that referenced
this pull request
Jan 22, 2023
This commit reverts a change with the previous fix for this flow: - #10088
7 tasks
geoff-vball
pushed a commit
that referenced
this pull request
Jan 22, 2023
This commit reverts a change with the previous fix for this flow: - #10088
geoff-vball
pushed a commit
that referenced
this pull request
Jan 27, 2023
This commit reverts a change with the previous fix for this flow: - #10088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Builds that we're supposed to push docker images were sometimes failing during the push step, because of a bug in the circleci config. Once this is merged, the push step should be skipped when it's not needed, and we'll no longer experience errors like the following:
https://app.circleci.com/pipelines/github/filecoin-project/lotus/25558/workflows/9b0c0540-8321-486c-b164-90fe76d5f177/jobs/759269
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps