Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: stub out the FileSize function on Windows #10035

Merged

Conversation

aschmahmann
Copy link
Contributor

Proposed Changes

Mocking out the FileSize function call in the sealer when built on Windows so that lotus library components can be used on Windows.

Additional Info

Would also be great to test that Windows library usage (e.g. of the state tree and actors) can continue to work on Windows even though running lotus and doing things like sealing isn't going to happen.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@aschmahmann aschmahmann requested a review from a team as a code owner January 17, 2023 06:07
@magik6k magik6k merged commit 2d3f1e0 into filecoin-project:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants