Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Update for go-graphsync v0.8.0 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hannahhoward
Copy link
Collaborator

Goals

Good news: The latest version of go-graphync and go-ipld-prime contains an important optimization to remove a bunch of unneccesary hashing when reading from local blockstores, which should cut down significantly on CPU usage
Bad news: The latest versions of these libraries contain a some important, but very breaking changes to syntax.
Good news: I'm updating them all the way to Lotus! And also, in most cases, from the point of view of the consuming libraries, they're simplifications.

Implementation

  • Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
  • Fix syntax changes -- linksystem over loader + storer.

Background

Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
@codecov-commenter
Copy link

Codecov Report

Merging #3 (428a269) into master (2f0b797) will decrease coverage by 1.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   55.68%   54.10%   -1.58%     
==========================================
  Files           3        3              
  Lines         176      146      -30     
==========================================
- Hits           98       79      -19     
+ Misses         63       52      -11     
  Partials       15       15              
Impacted Files Coverage Δ
store.go 100.00% <100.00%> (ø)
multistore.go 64.51% <0.00%> (-4.30%) ⬇️
mbstore.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0b797...428a269. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants