openStream: avoid time.Sleep in exponential backoff #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
changed the title
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
- Coverage 66.33% 66.19% -0.13%
==========================================
Files 48 48
Lines 3189 3197 +8
==========================================
+ Hits 2115 2116 +1
- Misses 830 837 +7
Partials 244 244
Continue to review full report at Codecov.
|
Stebalien
requested changes
Oct 9, 2020
Stebalien
approved these changes
Oct 9, 2020
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Stebalien
approved these changes
Oct 9, 2020
|
I mostly just pedantically avoid |
|
Merged in #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backoff logic was doing
time.Sleep(...)which isn't nice for handling cancelation.