[FIL-544] Fetch issue reporter handle #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
Filip-L
changed the title
kacperzuk-neti
requested changes
Jan 27, 2025
| rename = "Issue Reporter Handle", | ||
| skip_serializing_if = "Option::is_none" | ||
| )] | ||
| pub issue_reporter_handle: Option<String>, |
There was a problem hiding this comment.
Decide if we put this field as a separate column or in the app file. We can't have it in both places, as it risks desyncs.
fplus-lib/src/core/mod.rs
Outdated
Comment on lines
1274
to
1277
| if let Some(issue_reporter_handle) = app_file.issue_reporter_handle { | ||
| Some(issue_reporter_handle) | ||
| } else { | ||
| get_issue_reporter_handle(&app_file.id).await.map_err(|e| { |
There was a problem hiding this comment.
This should never be needed. If we have different values in app file and in the dedicated column, things are very broken already.
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
requested changes
Jan 28, 2025
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
approved these changes
Jan 28, 2025
Filip-L
force-pushed
the
FIL-544-fetch-issue-reporter-handle
branch
from
c02f0a5 to
a7064d1
Compare
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.