feat: use opencl3 based rust-gpu-tools #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Jun 1, 2021
dignifiedquire
previously approved these changes
Jul 6, 2021
|
@dignifiedquire I have no idea why your approval was removed. The only change since last review is that it now points to a merged commit instead of a branch, which I think is OK until a new proper version of rust-gpu-tools is out. |
|
I've pushed another commit. This PR now works with rust-gpu-tools current |
Upgrade to a version of rust-gpu-tools that is using `opencl3` instead of `ocl`. The local work size is now explicitly set and not longer automatically determined by the OpenCL implementation. `rust-gpu-tools` hasn't been released yet, so temporarily use a Git dependency, which points to a merged commit that works.
20 tasks
rust-gpu-tools had a few breaking changes, most notable: When creating kernels, the way the global work size has changed. it is no longer the total number of threads, but how many groups of local work size sized threads there are.
cryptonemo
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to a version of rust-gpu-tools that is using
opencl3insteadof
ocl.The local work size is now explicitly set and not longer automatically
determined by the OpenCL implementation.