Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fip proposing p256 address types #321

Closed
wants to merge 1 commit into from
Closed

Conversation

whyrusleeping
Copy link
Member

I've wanted this for a while, seems like better late than never.

## Abstract
Filecoin ramps should be as simple and available as possible, adding p256 opens up a whole new set of solutions for developers to integrate with.

## Change Motivation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, the iPhone also supports Curve25519 (https://developer.apple.com/documentation/cryptokit/curve25519) and the docs specify that the enclave supports "256bit elliptic curve algorithms". Are you sure it only supports P256?

Unfortunately, it looks like Android may only support RSA and P256.

Maybe we should just add support for both at the same time?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cost of adding two algorithms versus one is pretty minimal.

Copy link
Member Author

@whyrusleeping whyrusleeping Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the more the merrier, Curve25519 is getting a lot of traction too, and youre right, adding more is easy.

@kaitlin-beegle
Copy link
Contributor

Hey @whyrusleeping, would you mind adding this proposal/summary to the FIPs Discussion Forum too, so I can steward it for community feedback?

Thank you!

@kaitlin-beegle
Copy link
Contributor

Reached out again to FIP author to determine whether to merge or deprecate this draft.

@kaitlin-beegle
Copy link
Contributor

Closing PR, per this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants