-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP: gas model adjustment for user programmability. #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR accidentally duplicates part of #315. I've ignored the document fip-0032.md
in this review.
FIPS/fip-nnnn.md
Outdated
--- | ||
fip: "nnnn" | ||
title: Gas model adjustment for for user programmability | ||
author: Raúl Kripalani (@raulkr), Steven Allen (@stebalien) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in @raulkr
(also in fip-0032).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this. We really need a unified identity system :D
Weirdness happened here. This was based on top of the FIP-0032 branch, and the base branch was automatically changed to master when the former got merged. But GitHub screwed something up. |
58e9d41
to
7b1e4d0
Compare
7b1e4d0
to
d2110ad
Compare
Now that we're initiating Last Call on FVM FIPs 30-32, let's merge this FIP in as well in anticipation of upcoming work. FIP Editors, would you mind adding your review of the initial draft? @jennijuju @arajasek @momack2 @raulk, it looks as if this branch should easily merge into master now that #315 is merged, but lmk if you have concerns about the way the PR was set up. |
@@ -0,0 +1,238 @@ | |||
--- | |||
fip: "nnnn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIP0037!
This FIP follows #315, and introduces further gas model changes to address various aspects of user programmability.