Stable PCD: add note about checks being moved to ActivateDeals/ProveCommit #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle and
anorth
as code owners
anorth
approved these changes
Feb 24, 2022
anorth
pushed a commit
that referenced
this pull request
Mar 10, 2022
kaitlin-beegle
pushed a commit
that referenced
this pull request
May 12, 2022
) * First draft of FIP setting pre-commit deposit independent of sector content. * Stable PCD: add note about deal checks being moved to ActivateDeals (#309) * Compute and commit CommD at pre-commit and retain deal validity checks. Drop redundant deal loading for CommD during prove-commit. Note restoration of security buffers from SnapDeals. Co-authored-by: Jakub Sztandera <kubuxu@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @anorth