-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beneficiary address for miners #221
Conversation
(haven't done a full pass yet - will 👁️ more later this week. |
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I like this proposal, my comments are relatively minor. The only high importance one is confirming the beneficiary address to prevent the accidental loss of rewards.
I'll be pleased to approve this after that's addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I think this is good to land as draft status.
@kaitlin-beegle and FIP editors, can we please review and merge this PR? @arajasek and @magik6k this proposal would really benefit from your review too (doesn't have to block this PR, you can make comments in #253) |
I realised something else we should have here: a |
I think I have a question here is whether a contract needs to call an actor's method to get its status, or states can be gotten via system calls? e.g. we have a state structure standard (like JSON format as an example, or simply read a IPLD path), any actor's state can be read via a syscall if it follows the standard.
|
No, actors cannot read each other's state. They must call methods (so an actor's internal state is abstracted). It's not very explicit in Go because we control all the actors, but will be enforced in the FVM. |
We should add |
This is to propose a beneficiary address to take finance control of a miner from owner.
See the discussions from #253