Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beneficiary address for miners #221

Merged
merged 13 commits into from
Feb 4, 2022
Merged

Beneficiary address for miners #221

merged 13 commits into from
Feb 4, 2022

Conversation

steven004
Copy link
Contributor

@steven004 steven004 commented Dec 10, 2021

This is to propose a beneficiary address to take finance control of a miner from owner.
See the discussions from #253

FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
@jennijuju
Copy link
Member

(haven't done a full pass yet - will 👁️ more later this week.

steven004 and others added 2 commits December 17, 2021 10:56
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
@kaitlin-beegle kaitlin-beegle changed the title fip-0028 beneficiary address for miners Beneficiary address for miners Jan 7, 2022
steven004 and others added 3 commits January 7, 2022 14:53
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I like this proposal, my comments are relatively minor. The only high importance one is confirming the beneficiary address to prevent the accidental loss of rewards.

I'll be pleased to approve this after that's addressed.

FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Outdated Show resolved Hide resolved
FIPS/fip-0028.md Show resolved Hide resolved
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think this is good to land as draft status.

@hunjixin
Copy link

@anorth
Copy link
Member

anorth commented Jan 31, 2022

@kaitlin-beegle and FIP editors, can we please review and merge this PR?

@arajasek and @magik6k this proposal would really benefit from your review too (doesn't have to block this PR, you can make comments in #253)

@anorth
Copy link
Member

anorth commented Feb 1, 2022

I realised something else we should have here: a GetBeneficiary method to read the beneficiary address, quota, and expiration from the miner. I'm thinking forward to FVM smart contracts here: a contract beneficiary will need to be able to on-chain confirm that it is indeed the beneficiary and for how long.

@steven004
Copy link
Contributor Author

steven004 commented Feb 1, 2022 via email

@anorth
Copy link
Member

anorth commented Feb 1, 2022

No, actors cannot read each other's state. They must call methods (so an actor's internal state is abstracted). It's not very explicit in Go because we control all the actors, but will be enforced in the FVM.

@anorth
Copy link
Member

anorth commented Feb 2, 2022

We should add GetProposedBeneficiary too so that a contract or UI can read the proposal in order to submit matching configuration to confirm it.

@kaitlin-beegle kaitlin-beegle merged commit b37b4a6 into filecoin-project:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants