Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PublishStorageDeals error handling fip #154

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Add PublishStorageDeals error handling fip #154

merged 3 commits into from
Sep 22, 2021

Conversation

ZenGround0
Copy link
Contributor

Discussion here: #142

arajasek
arajasek approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested changes, but can be merged

_fips/fip-publish-deals-ret.md Outdated Show resolved Hide resolved
_fips/fip-publish-deals-ret.md Outdated Show resolved Hide resolved
_fips/fip-publish-deals-ret.md Show resolved Hide resolved
_fips/fip-publish-deals-ret.md Outdated Show resolved Hide resolved
_fips/fip-publish-deals-ret.md Outdated Show resolved Hide resolved
@ZenGround0 ZenGround0 mentioned this pull request Sep 7, 2021
Closed
@kaitlin-beegle
Copy link
Contributor

Hey @ZenGround0, would you mind addressing outstanding comments before I merge this request?

arajasek
arajasek approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproved, thanks for incorporating feedback!

@kaitlin-beegle kaitlin-beegle merged commit 43c4479 into master Sep 22, 2021
@kaitlin-beegle kaitlin-beegle deleted the fip/publish-deals-return branch September 22, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitlin-beegle kaitlin-beegle kaitlin-beegle left review comments

@arajasek arajasek arajasek approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

@jennijuju jennijuju Awaiting requested review from jennijuju jennijuju is a code owner

@momack2 momack2 Awaiting requested review from momack2 momack2 is a code owner

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZenGround0 @kaitlin-beegle @arajasek