-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After 2.0.8 does not display the repository icon #518
Comments
Screenshot, please. |
Odd. Does emptying the cache and restarting help...? |
Did not help, unfortunately. If i replace "icon-file-directory" to "icon-repo" in inspector, then repository icon appears. But, obviously, after restarting disappeared again. |
Are other Git projects affected? What happens if you remove the @hellfish2 Is this what you were talking about in #513? |
Any git projects affected. After removing and adding the project, appeared "file-directory" icon again. I even tried to reinstall Atom, it did not help. But everything works fine on version 2.0.7. |
*sigh* This will be hard to pinpoint... First, run this in your console: var AtomFS = require(atom.packages.activePackages["file-icons"].path + "/lib/filesystem/filesystem.js");
console.log(AtomFS.paths); Then click the |
Ah-HAH. Makes sense now. |
@SologubVS I pushed a fix. Can you clone from master and tell me if it works? # Close Atom, then run these steps in your terminal:
git clone https://github.com/file-icons/atom.git file-icons
cd file-icons
apm install . && apm link .
# Start Atom
atom |
Yes! Now displays the correct icon, thanks! |
This was the reason it wasn't working: const isRepository = repoPath === resourcePath; Which, of course, is always going to be const resourcePath = "J:\OpenServer\dmn\localhost\node-dev\wp-content\themes\node";
const repoPath = "J:/OpenServer/dmn/localhost/node-dev/wp-content/themes/node"; |
@SologubVS You should see this fixed in v2.0.10. :) Please let me know if you see it again. |
@Alhadis I saw, thanks! I let you know, of cause. Now all is well. |
Instead, display the classic folders icon.
Problem occurs in version 2.0.8 and 2.0.9.
I fell back to version 2.0.7 and the problem disappeared.
For some reason, instead of the class "icon-repo" appears the class "icon-file-directory" in tree-view layout.
The text was updated successfully, but these errors were encountered: