Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Htmlable filter indicator label #11281

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Htmlable filter indicator label #11281

merged 3 commits into from
Feb 7, 2024

Conversation

cawecoy
Copy link
Contributor

@cawecoy cawecoy commented Feb 7, 2024 •
edited
Loading

Description

Allowing Filament\Tables\Filters\Indicator to be labeled with Illuminate\Support\HtmlString, i.e.:

\Filament\Tables\Filters\Indicator::make('field')->label(new \Illuminate\Support\HtmlString('<span class="custom-class">Indicator lable</span>'))
  • Visual changes (if any) are shown using screenshots/recordings of before and after.

Code style

  • composer cs command has been run.

Testing

  • Changes have been tested.

Documentation

  • Documentation is up-to-date.

@danharrin danharrin added the enhancement New feature or request label Feb 7, 2024
@danharrin danharrin added this to the v3 milestone Feb 7, 2024
@danharrin danharrin merged commit 993f735 into filamentphp:3.x Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Roadmap
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@cawecoy @danharrin