Removed manual step in installation of requirements #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual install break automatic processes like Docker build, so it's better if we can automate it. I'm still looking for a solution to make Windows dependencies optionnals.
The pywin32 would break installation on a Linux as pip could not find a suitable build, as the only binaries available are for win32. So I made it made optional for others platforms. I also made pyinstaller optional, does it make sense to include it in other platforms ? Is it used in another way that when building the .exe files ? If yes, feel free to revert the change.
|
The pywin32 would break installation on a Linux as pip could not find a suitable build, as the only binaries available are for win32. I also made pyinstaller optional, does it make sense to include it in other platforms ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual install breaks automatic processes like Docker build, so it's better if we can automate it.
I'm still looking for a solution to make Windows dependencies optional, so they would not be installed in a linux env.