Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with multiple classes #355

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

SandroHc
Copy link
Contributor

Fixes all locations where multiple classes were not working as expected. Example that was failing before:

<table></table>
<script>
    new DataTable("table", {
        classes: {
            container: "my-container second-class",
        }
    })
</script>

This should be my last change for a while. Your support throughout these past days has been greatly appreciated!

@johanneswilm
Copy link
Member

Looks good! Could you also add a note that the class name combinations need to be unique and it's not possible to use an empty string as the class names are used for the internal workings of sdt.

@SandroHc
Copy link
Contributor Author

Done! Just finishing up the merge conflicts now.

Fixes all locations where multiple classes were not working as expected.

Example that was failing before:
```html
<table></table>
<script>
    new DataTable("table", {
        classes: {
            container: "my-container second-class",
        }
    })
</script>
```
@SandroHc
Copy link
Contributor Author

Merge conflicts fixed

@johanneswilm johanneswilm merged commit fba35f7 into fiduswriter:main Nov 27, 2023
2 checks passed
@SandroHc SandroHc deleted the multiple-classes branch November 27, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants