Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for typing.Dict types #231

Merged
merged 5 commits into from
Mar 17, 2022
Merged

Adds support for typing.Dict types #231

merged 5 commits into from
Mar 17, 2022

Conversation

ncilfone
Copy link
Contributor

What does this PR do?

Added support for typing.Dict types with type checking for types of both keys and values (includes advanced types
such as Dict[str, Tuple[Callable, Callable]])

Checklist

  • Did you adhere to PEP-8 standards?
  • Did you run black and isort prior to submitting your PR?
  • Does your PR pass all existing unit tests?
  • Did you add associated unit tests for any additional functionality?
  • Did you provide documentation (Google Docstring format) whenever possible, even for simple functions or classes?

@ncilfone ncilfone added documentation Improvements or additions to documentation enhancement New feature or request tests Unit tests labels Mar 17, 2022
@coveralls
Copy link

coveralls commented Mar 17, 2022

Pull Request Test Coverage Report for Build 1999629553

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 244 of 251 (97.21%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 96.018%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spock/backend/typed.py 15 16 93.75%
spock/backend/field_handlers.py 32 35 91.43%
spock/backend/utils.py 66 69 95.65%
Totals Coverage Status
Change from base Build 1981256000: 0.6%
Covered Lines: 1929
Relevant Lines: 2009

💛 - Coveralls

@ncilfone ncilfone merged commit 8617af6 into master Mar 17, 2022
@ncilfone ncilfone deleted the dict-type branch March 21, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request tests Unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants