Add Zip64 support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two zip64 archives from https://go.dev/src/archive/zip/reader_test.go to test zip64 support when reading.
|
Works amazing for me! It should be merged soon as this seems to be the defacto julia zipfile library, zip64 is essential to many projects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I took @barcharcraz 's PR #28 from a few years back and rebased it on the current master. As you suggested in that PR I also added Unit tests similar to the tests from here.
This should fix #56 and also this bug in NPZ.jl, at least when reading > 4GB files.
For Writing zip64 I started with the implementation, but I'm not finished yet. Maybe you want that in a separate PR. Alternatively I can add it right here, but I'm not sure when I will have time again to finish this.
Regards,
maj0e