Try to detect failed syncs and display appropriate error message

fholger · Jan 26, 2025 · fdc27a0 · fdc27a0
1 parent a01bc71
commit fdc27a0
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/Code/VR/VRManager.cpp b/Code/VR/VRManager.cpp
@@ -1337,15 +1337,35 @@ void VRManager::AcquireTextureSync(ID3D10Texture2D* target, int key)
 	if (target == nullptr) return;
 	ComPtr<IDXGIKeyedMutex> mutex;
 	target->QueryInterface(__uuidof(IDXGIKeyedMutex), (void**)mutex.GetAddressOf());
-	CHECK_D3D10(mutex->AcquireSync(key, 100));
+	HRESULT hr = mutex->AcquireSync(key, 100);
+	if (FAILED(hr))
+	{
+		CryLogAlways("Failed to sync D3D10 textures: %i", hr);
+		++m_numFailedSyncs;
+		if (m_numFailedSyncs > 200 && !m_shownSyncFailureMessage)
+		{
+			MessageBoxA(nullptr, "Cannot sync textures between the game and the VR runtime. If you are using MSI Afterburner / Rivatuner or similar overlays, disable them and restart the game.", "Render error", MB_OK);
+			m_shownSyncFailureMessage = true;
+		}
+	}
 }
 
 void VRManager::AcquireTextureSync(ID3D11Texture2D* target, int key)
 {
 	if (target == nullptr) return;
 	ComPtr<IDXGIKeyedMutex> mutex;
 	target->QueryInterface(__uuidof(IDXGIKeyedMutex), (void**)mutex.GetAddressOf());
-	CHECK_D3D10(mutex->AcquireSync(key, 100));
+	HRESULT hr = mutex->AcquireSync(key, 100);
+	if (FAILED(hr))
+	{
+		CryLogAlways("Failed to sync D3D11 textures: %i", hr);
+		++m_numFailedSyncs;
+		if (m_numFailedSyncs > 200 && !m_shownSyncFailureMessage)
+		{
+			MessageBoxA(nullptr, "Cannot sync textures between the game and the VR runtime. If you are using MSI Afterburner / Rivatuner or similar overlays, disable them and restart the game.", "Render error", MB_OK);
+			m_shownSyncFailureMessage = true;
+		}
+	}
 }
 
 void VRManager::ReleaseTextureSync(ID3D10Texture2D* target, int key)

diff --git a/Code/VR/VRManager.h b/Code/VR/VRManager.h
@@ -149,6 +149,9 @@ class VRManager
 	ray_hit m_offHandRayHit;
 	bool m_offHandRayHitAny = false;
 	EntityId m_pointAtEntityId;
+
+	int m_numFailedSyncs = 0;
+	bool m_shownSyncFailureMessage = false;
 };
 
 extern VRManager* gVR;