Update BsnUtil.java #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bsn can be send to 3rd parties who expect a Numeric 8-9 value. eg 005084039 will be send as 5084039. This will be rejected.
assertThat(bsnUtil.testBsn("005084039")).isFalse();
fhoeben
reviewed
Jul 22, 2021
| @@ -23,7 +23,7 @@ public String generateBsn() { | |||
| int Nr2 = randomUtil.random(10); | |||
| int Nr1 = 0; | |||
| int SofiNr = 0; | |||
| if ((Nr9 == 0) && (Nr8 == 0) && (Nr7 == 0)) { | |||
| if (Nr9 == 0 && Nr8 == 0) { | |||
There was a problem hiding this comment.
Why did you remove the third clause here (I have to admit I don't actually know this generation code very well, but you don't mention this in your PR text).
There was a problem hiding this comment.
@pvreeuwijk was this removal intentional? Can you explain to me why this clause should not (or does not have to) be there?
Co-authored-by: Fried Hoeben <github@hsac.nl>
moved starts with check "00" next to bsn.length() != 9 check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bsn can be send to 3rd parties who expect a Numeric 8-9 value. eg 005084039 will be send as 5084039. This will be rejected.
assertThat(bsnUtil.testBsn("005084039")).isFalse();