Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL for the wget download file example #70

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

sckott
Copy link
Member

@sckott sckott commented Oct 5, 2023

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Fix a URL to a file

What was your approach?

Find the correct URL, test that it works, commit changes, make PR

What GitHub issue does your pull request address?

None

Tell potential reviewers what kind of feedback you are soliciting.

Is this correct?

New Content Checklist

I don't think any of this stuff was releavant, but please do let me know if it was

@sckott
Copy link
Member Author

sckott commented Oct 5, 2023

Waiting on #69

@avahoffman
Copy link
Contributor

@sckott everything should be up to date GHA-wise - please merge in changes from main to re-render, thanks!

@sckott
Copy link
Member Author

sckott commented Oct 6, 2023

@avahoffman thx, but it looks like merging is blocked because review is required. i may have different permissions than you

@avahoffman
Copy link
Contributor

Looks like you're on a fork - can you pull fhdsl:main first to update this PR?

@cansavvy
Copy link
Contributor

cansavvy commented Oct 6, 2023

Forks can't initiate workflows. It's something I don't like but there's not a setting around it that I've seen yet.

@sckott
Copy link
Member Author

sckott commented Oct 6, 2023

updated my feature branch on my fork. yeah, i didn't have access to make a branch here, so forked. let me know how to proceed 😄

@avahoffman
Copy link
Contributor

Forks can't initiate workflows. It's something I don't like but there's not a setting around it that I've seen yet.

That's annoying lol

But obviously the link looks fine. Thanks!

@avahoffman avahoffman merged commit 49586b6 into fhdsl:main Oct 6, 2023
5 of 6 checks passed
@sckott sckott deleted the patch-1 branch October 6, 2023 15:35
@sckott
Copy link
Member Author

sckott commented Oct 6, 2023

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants