Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved grammar and visual appearance #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Sanaz01
Copy link
Collaborator

@Sanaz01 Sanaz01 commented Mar 10, 2024

Purpose/implementation Section

What changes are being implemented in this Pull Request?

What was your approach?

What GitHub issue does your pull request address?

Tell potential reviewers what kind of feedback you are soliciting.

New Content Checklist

Copy link
Contributor

github-actions bot commented Mar 10, 2024

⚠️ broken urls ⚠️
There are broken urls that need to be addressed.
Click here ➡️ for broken urls errors!
Add errors that aren't errors to the resources/ignore-urls.txt file of this repo.
If you are having troubles see this guide
Comment updated at 2024-03-10 with changes from 64bf2bc

Copy link
Contributor

github-actions bot commented Mar 10, 2024

⚠️ spelling ⚠️
There are spelling that need to be addressed.
Click here ➡️ for spelling errors!
Add errors that aren't errors to the resources/dictionary.txt file of this repo.
If you are having troubles see this guide
Comment updated at 2024-03-10 with changes from 64bf2bc

Copy link
Contributor

Re-rendered previews from the latest commit:

Updated at 2024-03-10 with changes from 64bf2bc

@caalo
Copy link
Collaborator

caalo commented Mar 14, 2024

Thanks for your edits, this is helpful!

I'd take all the edits except:

  • I prefer just a plain File to describe the File variable type. No formatting please.
  • We are planning to embed GitHub gists for our workflow code, so unfortunately we can't incorporate your syntax higlighting, despite as visually nice it looks.

Other files besides .Rmd were made - not sure if it was by intention. Seems to be causing merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants