Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

[WIP] Private networks #298

Closed
wants to merge 6 commits into from
Closed

[WIP] Private networks #298

wants to merge 6 commits into from

Conversation

fgrehm
Copy link
Owner

@fgrehm fgrehm commented Jun 9, 2014

I had a need for private networks last week and this is my first stab at implementing GH-120

TODO

  • Integrate pipework into the plugin
  • Remove docker specifics from the script not worth the trouble and will make things harder when bringing in upstream changes.
  • Make it work with a single ip range (192.168.1.X)
  • Clean up when shutting down container (use brctl show brX to check if in use and ip link delete brX to clean up)
  • Make it work for any ip range / create multiple bridges Decided to keep things simple and will require the bridge name to be set
  • Validate if bridge name is set
  • Create bridge only if it is not up
  • Make sure it works when bringing up containers in parallel
  • Whitelist sudo for private network script execution
  • Improve logging / provide information when networking is being configured / deconfigured

@PierrePaul PierrePaul mentioned this pull request Jul 4, 2014
@fgrehm fgrehm mentioned this pull request Jul 25, 2014
7 tasks
@fgrehm
Copy link
Owner Author

fgrehm commented Sep 23, 2014

For those interested on this, unfortunately this is not coming in for 1.0, things are pretty stable right now and the time for a stable 1.0 has past a long time ago ;-)

@fgrehm
Copy link
Owner Author

fgrehm commented Jan 11, 2015

An experimental support for this is available at the next branch and will be released with 1.1.0 (expected at some point in jan / feb)

Docs will come along with the release but for the brave souls willing to build the plugin from sources and give it a spin this is what you'll need to set from the Vagrantfile:

  config.vm.network "private_network", ip: "CONTAINER_IP", lxc__bridge_name: 'BRIDGE_NAME'

lxc__bridge_name is currently required. Support for using a "dynamic name" will be added post 1.1.0

@fgrehm fgrehm closed this Jan 11, 2015
@fgrehm fgrehm deleted the private-networks branch January 11, 2015 23:03
@Ramblurr
Copy link

If using virbr0 provided by libvirtd, as outlined in the fedora wiki entry, does the lxc__bridge_name field need to be set to virbro0?

@fgrehm
Copy link
Owner Author

fgrehm commented Mar 8, 2015

Yes, right now the config has to be set at all times.

@moos3
Copy link

moos3 commented Mar 8, 2016

I noticed they can ping reach other but can't talk to each other on ports. I have verified my firewall settings on my multiple node Vagrant file. Thoughts or Ideas? Seems to be related to this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants