This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Clone support #233
Closed
Clone support #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also covers #232 |
| @@ -66,6 +68,13 @@ def create(template, config_file, template_opts = {}) | |||
| end | |||
| end | |||
|
|
|||
| def clone(existing_container_name, name) | |||
There was a problem hiding this comment.
Ah good point, I'll clean that up.
|
I like the explicit clone approach here. Seems maybe less treacherous than trying build transparent cloning support into the basic create functionality. We're using btrfs here -- I'll merge this into my fork and give it a try this week. |
|
So this seems to work nicely under btrfs. |
|
Damn, GitHub automagically closed the PR because I deleted the referenced branch =/ @ccope would you mind opening a new PR so we can continue the discussion? Thanks in advance! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code works for me on Ubuntu 12.04 and 13.10 with LVM, with the exception of shared folders. I'm working on a commit for that this weekend. This should work for btrfs and others as well.