Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made compatible with Rails 3 #92

Closed
wants to merge 2 commits into from
Closed

Made compatible with Rails 3 #92

wants to merge 2 commits into from

Conversation

gbonline
Copy link

No description provided.

@pseudomuto
Copy link
Contributor

Hey @gbonline, sorry for the very late response. In the future please @ me in the PR description so I get notified.

At this point, Rails 3 (even 4) is very old and not something I'd want to take on. Is this still an issue for you?

@gbonline
Copy link
Author

gbonline commented Feb 3, 2020

Hi, Pseudomuto
maybe do you speak italian? your name sound italiano...
I've used this gem on a old project, the client of the project wanted to update, so I took everything back in hand and installed the new gems. This one didn't work anymore on the project, so I customized it for the rails 3 version, then I proposed to update it with a little modify to make it compatible with the old rails.
Answering your question "Is still an issue for you?", No anymore.
best regards

@fgrehm
Copy link
Owner

fgrehm commented Feb 18, 2020

@pseudomuto At this point, Rails 3 (even 4) is very old and not something I'd want to take on.

Me neither 😅

@gbonline Answering your question "Is still an issue for you?", No anymore.

Awesome, I guess we can close this, @pseudomuto when me or you have the time, lets bump the deps on the gemspec

gem.add_dependency 'actionmailer', '>= 3.2'
gem.add_dependency 'letter_opener', '~> 1.0'
gem.add_dependency 'railties', '>= 3.2'

I'll create a ticket for that so we don't forget

@fgrehm fgrehm closed this Feb 18, 2020
@fgrehm
Copy link
Owner

fgrehm commented Feb 18, 2020

@gbonline forgot to say: thank you for your contributions and sorry we took so long to get back to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants