Prefer reading header from rich style over plain one #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tricknotes
commented
Oct 20, 2021
| @@ -4,7 +4,7 @@ on: | |||
| push: | |||
| branches: [ master ] | |||
| pull_request: | |||
| branches: [ master ] | |||
| branches: [ master, next ] | |||
There was a problem hiding this comment.
I want to run CI on this PR.
If you don't like this change, I can separate this from this PR and will discuss in another PR.
tricknotes
force-pushed
the
correct-headers
branch
from
b66ab42 to
104bd2f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Hi, @fgrehm
I'm looking forward to letter_opener_web 2.0.0.
I cant't wait a new release, so I try to use #113.
What is this
I found issues about reading headers.
NoMethodError: undefined method `[]' for nil:NilClass.This PR fixes them.