Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug visualização de header para administradores #92

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

AntonioIgorCarvalho
Copy link
Collaborator

Closes fga-eps-mds/2021.1-Oraculo#210

Descrição:

  • Function ValidateAdmin fixed

Co-authored-by: Gabriel Santos Silva Araújos <gabrielsantos_s96@hotmail.com>
Copy link
Collaborator

@lucasvmx lucasvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validação sendo feita da forma correta, só sugiro que coloque esses valores 1 e 2 armazenados numa constante para que fique claro o que eles significam. tipo assim:

const adminPrivilege = 1;
const commonPrivilege = 2;

…aculo#210

Co-authored-by: Antonio Igor Carvalho <antonioigorcarvalho@gmail.com>
Co-authored-by: Gabriel Santos Silva Araújos <gabrielsantos_s96@hotmail.com>
@lucasvmx lucasvmx requested review from Henrike100, Maxlobo and joaoCeilandia and removed request for GabrielSSAraujo November 11, 2021 01:35
Copy link
Collaborator

@VictorRodriguesS0 VictorRodriguesS0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabéns

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

@Henrike100 Henrike100 merged commit 2949f91 into devel Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrigir bug visualização dos usuários administradores
5 participants