Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

195 resolver code smells #77

Merged
merged 26 commits into from
Nov 9, 2021
Merged

195 resolver code smells #77

merged 26 commits into from
Nov 9, 2021

Conversation

AntonioIgorCarvalho
Copy link
Collaborator

Closes fga-eps-mds/2021.1-Oraculo#195

Descrição:
Foram corrigidos:

  • Diversos code smells apontados pelo sonarcloud
  • Código duplicado
  • 1 Bug

AntonioIgorCarvalho and others added 26 commits November 8, 2021 21:28
@AntonioIgorCarvalho @VictorRodriguesS0
Removed unused function fga-eps-mds/2021.1-Oraculo#195
ea2a66e 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Unused import removed fga-eps-mds/2021.1-Oraculo#195
55e4a1b 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Unused imports removed fga-eps-mds/2021.1-Oraculo#195
c8cf6ee 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Unused import removed fga-eps-mds/2021.1-Oraculo#195
11ff0b2 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Unused import removed fga-eps-mds/2021.1-Oraculo#195
d566ac9 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Unused import removed fga-eps-mds/2021.1-Oraculo#195
b9f68a3 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Unused imports removed fga-eps-mds/2021.1-Oraculo#195
53935f0 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Unused imports of SearchBar removed fga-eps-mds/2021.1-Oraculo#195
89301ba 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Code smells fixed fga-eps-mds/2021.1-Oraculo#195
9313a60 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Empty function removed fga-eps-mds/2021.1-Oraculo#195
90bb9c8 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Consts created do avoid similar strings fga-eps-mds/2021.1-Oraculo#195
cbbecb0 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Const created to avoid similar strings fga-eps-mds/2021.1-Oraculo#195
994284d 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Duplicated code reduced fga-eps-mds/2021.1-Oraculo#195
4c3adf1 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Function return refactored fga-eps-mds/2021.1-Oraculo#195
b68e571 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Function return refactored fga-eps-mds/2021.1-Oraculo#195
5236fca 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Function refactored fga-eps-mds/2021.1-Oraculo#195
11e26f6 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Function return condition unified fga-eps-mds/2021.1-Oraculo#195
67f3b70 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
== changed to === fga-eps-mds/2021.1-Oraculo#195
4848f2b 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Function refactored fga-eps-mds/2021.1-Oraculo#195
1f3c169 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
== changed to === fga-eps-mds/2021.1-Oraculo#195
7251477 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Return in error conditions added fga-eps-mds/2021.1-Oraculo#195
7f181ea 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Unused parameter removed fga-eps-mds/2021.1-Oraculo#195
c3e60e5 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho @VictorRodriguesS0
Error fixed fga-eps-mds/2021.1-Oraculo#195
1936826 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@AntonioIgorCarvalho
Merge branch 'devel' of github.com:fga-eps-mds/2021.1-Oraculo-FrontEn…
70af201 
…d into 195-resolver-code-smells
@AntonioIgorCarvalho
Button removed
9ec5859
@AntonioIgorCarvalho @VictorRodriguesS0
Error fixed fga-eps-mds/2021.1-Oraculo#195
99e5c55 
Co-authored-by: Victor Rodrigues <victorrsilva17@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

1.1% 1.1% Coverage
0.0% 0.0% Duplication

@ericoBandeira ericoBandeira merged commit f2d7ced into devel Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericoBandeira ericoBandeira ericoBandeira approved these changes

@Maxlobo Maxlobo Maxlobo approved these changes

@lucasvmx lucasvmx Awaiting requested review from lucasvmx

@joaoCeilandia joaoCeilandia Awaiting requested review from joaoCeilandia

Assignees

@VictorRodriguesS0 VictorRodriguesS0

@AntonioIgorCarvalho AntonioIgorCarvalho

Labels
EPS HOTFIX MDS MEDIUM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolver Code Smells no Front-end
4 participants
@AntonioIgorCarvalho @ericoBandeira @Maxlobo @VictorRodriguesS0