Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ff_league should return the season as a column of the dataframe #287

Closed
tanho63 opened this issue May 16, 2021 · 4 comments · Fixed by #288
Closed

ff_league should return the season as a column of the dataframe #287

tanho63 opened this issue May 16, 2021 · 4 comments · Fixed by #288
Labels
feature 🌟 a feature request or enhancement
Milestone
1.4.3

Comments

@tanho63
Copy link
Member

tanho63 commented May 16, 2021

No description provided.

@joeflan
Copy link
Contributor

joeflan commented May 26, 2021

I forked this and I'm going to start taking a look

@tanho63
Copy link
Member Author

tanho63 commented May 26, 2021

Nice! It’s a pretty simple fix, just add season = conn$season to the returned tibble

@tanho63 tanho63 added feature 🌟 a feature request or enhancement good first issue 🚪 easy wins for new contributors labels May 26, 2021
joeflan added a commit to joeflan/ffscrapr that referenced this issue May 27, 2021
@joeflan
adding season to ff_league function
5e7663a 
Fixes ffverse#287
@tanho63 tanho63 linked a pull request May 27, 2021 that will close this issue
Adding season to ff league function #288
Merged
@tanho63 tanho63 changed the title ff_league should return the season as a row of the dataframe ff_league should return the season as a column of the dataframe May 27, 2021
@joeflan
Copy link
Contributor

joeflan commented May 27, 2021

Is the issue officially closed when the changes are merged into main?

@tanho63
Copy link
Member Author

tanho63 commented May 27, 2021

Yeah, hopefully automatically but sometimes I go back and clean them. This is definitely fully completed though

@tanho63 tanho63 removed the good first issue 🚪 easy wins for new contributors label May 28, 2021
@tanho63 tanho63 added this to the 1.4.3 milestone May 28, 2021
@tanho63 tanho63 added the release pending ⏳ this feature/bug is resolved in the development version label Jun 8, 2021
@tanho63 tanho63 removed the release pending ⏳ this feature/bug is resolved in the development version label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature 🌟 a feature request or enhancement
Projects
None yet
Milestone
1.4.3
Development

Successfully merging a pull request may close this issue.

Adding season to ff league function joeflan/ffscrapr
2 participants
@joeflan @tanho63