Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current age in ff_draft() #259

Closed
TheMathNinja opened this issue Apr 9, 2021 · 1 comment · Fixed by #263
Closed

Current age in ff_draft() #259

TheMathNinja opened this issue Apr 9, 2021 · 1 comment · Fixed by #263
Labels
bug 🐛 an unexpected problem or unintended behavior

Comments

@TheMathNinja
Copy link
Contributor

I'm using the ff_draft() function on an MFL object and realizing that the age variable is showing the player's current age rather than age at the time of draft. Is this how it is meant to perform? It seems like age at the time the pick was made might be more useful.

@tanho63
Copy link
Member

tanho63 commented Apr 9, 2021

Probably lazy joining mfl players rather than redoing math. Can be fixed, not sure if will make next CRAN update. (Possibly).

@tanho63 tanho63 added the bug 🐛 an unexpected problem or unintended behavior label Apr 13, 2021
@tanho63 tanho63 linked a pull request Apr 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants