Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ko.json #26

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Create ko.json #26

merged 2 commits into from
Mar 22, 2020

Conversation

2hochan
Copy link
Contributor

@2hochan 2hochan commented Aug 1, 2019

Please create pull requests to the branch develop.

  • Does the pull request solve an issue (add a reference)?
  • What are the features of this pr?
  • Add screenshots for visual changes.

@fewieden
Copy link
Owner

fewieden commented Aug 6, 2019

@2hochan thanks for your contribution.

There are a few things you need to address in order to merge it.

  • Your PR should point towards develop not master
  • You also need to link your file in the method getTranslations of MMM-AlarmClock.js

@fewieden fewieden changed the base branch from master to develop March 22, 2020 19:34
@fewieden fewieden merged commit 8286a04 into fewieden:develop Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants