Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of eslint is breaking the build 🚨 #550

Closed
greenkeeper bot opened this issue Aug 18, 2019 · 3 comments
Closed

An in-range update of eslint is breaking the build 🚨 #550

greenkeeper bot opened this issue Aug 18, 2019 · 3 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Aug 18, 2019

The dependency eslint was updated from 6.1.0 to 6.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ci/circleci: build: CircleCI is running your tests (Details).
  • ci/circleci: build4next: Your tests failed on CircleCI (Details).

Release Notes for v6.2.0
  • fee6acb Update: support bigint and dynamic import (refs #11803) (#11983) (Toru Nagashima)
  • afd8012 New: noInlineConfig setting (refs eslint/rfcs#22) (#12091) (Toru Nagashima)
  • 3d12378 Update: Fix accessor-pairs to enforce pairs per property in literals (#12062) (Milos Djermanovic)
  • 8cd00b3 New: function-call-argument-newline (#12024) (finico)
  • 30ebf92 Fix: prefer-template autofix produces syntax error with octal escapes (#12085) (Milos Djermanovic)
  • 13c3988 Fix: Check literal type explicitly in dot-notation (#12095) (Milos Djermanovic)
  • 3e5ceca Fix: Handle empty string property names in getFunctionNameWithKind (#12104) (Milos Djermanovic)
  • 9a043ff Fix: no-duplicate-case false positives on Object.prototype keys (#12107) (Milos Djermanovic)
  • fe631af Chore: minor typo fix (#12112) (James George)
  • 4cb7877 Fix: fix no-extra-parens ignores some nodes (#11909) (Pig Fang)
  • 2dc23b8 Update: fix no-dupe-keys false negatives on empty string names (#12069) (Milos Djermanovic)
  • 19ab666 Fix: yoda exceptRange false positives on empty string property names (#12071) (Milos Djermanovic)
  • d642150 Update: Check empty string property names in sort-keys (#12073) (Milos Djermanovic)
  • acce6de Fix: class-methods-use-this reports 'undefined' names (#12103) (Milos Djermanovic)
  • 92ec2cb Fix: Allow bind call with a single spread element in no-extra-bind (#12088) (Milos Djermanovic)
  • bfdb0c9 Fix: no-extra-boolean-cast invalid autofix for Boolean() without args (#12076) (Milos Djermanovic)
  • 34ccc0c Chore: Remove TDZ scope type condition from no-unused-vars (#12055) (Milos Djermanovic)
  • 01d38ce Docs: Remove TDZ scope from the scope manager interface documentation (#12054) (Milos Djermanovic)
  • 1aff8fc Update: warn about mixing ternary and logical operators (fixes #11704) (#12001) (Karthik Priyadarshan)
  • 11be2f8 Docs: do not recommend global-installed usage (#12016) (薛定谔的猫)
  • cf31dab Fix: no-restricted-syntax - correct the schema (#12051) (Brad Zacher)
  • fbec99e Update: fix class-methods-use-this false negatives with exceptMethods (#12077) (Milos Djermanovic)
  • fb08b7c Docs: Remove readonly/writable global logic from no-undef (fixes #11963) (#12053) (Milos Djermanovic)
  • 5b5934b Sponsors: Sync README with website (ESLint Jenkins)
  • 9156760 Sponsors: Sync README with website (ESLint Jenkins)
  • f5e0cc4 Update: Check computed method keys in no-extra-parens (#11973) (Milos Djermanovic)
  • d961438 Docs: Fix Incorrect Documentation (#12045) (Michael Miceli)
  • 887d08c Sponsors: Sync README with website (ESLint Jenkins)
  • d90183f Docs: add a case to func-names (#12038) (Chiawen Chen)
  • 8a5b62d Docs: no use eslint.linter in code example (#12037) (薛定谔的猫)
  • 5831767 Update: report location of func-names (fixes #12022) (#12028) (Pig Fang)
Commits

The new version differs by 33 commits.

  • 320b7bd 6.2.0
  • 9601f5a Build: changelog update for 6.2.0
  • fee6acb Update: support bigint and dynamic import (refs #11803) (#11983)
  • afd8012 New: noInlineConfig setting (refs eslint/rfcs#22) (#12091)
  • 3d12378 Update: Fix accessor-pairs to enforce pairs per property in literals (#12062)
  • 8cd00b3 New: function-call-argument-newline (#12024)
  • 30ebf92 Fix: prefer-template autofix produces syntax error with octal escapes (#12085)
  • 13c3988 Fix: Check literal type explicitly in dot-notation (#12095)
  • 3e5ceca Fix: Handle empty string property names in getFunctionNameWithKind (#12104)
  • 9a043ff Fix: no-duplicate-case false positives on Object.prototype keys (#12107)
  • fe631af Chore: minor typo fix (#12112)
  • 4cb7877 Fix: fix no-extra-parens ignores some nodes (#11909)
  • 2dc23b8 Update: fix no-dupe-keys false negatives on empty string names (#12069)
  • 19ab666 Fix: yoda exceptRange false positives on empty string property names (#12071)
  • d642150 Update: Check empty string property names in sort-keys (#12073)

There are 33 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 18, 2019

After pinning to 6.1.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@fetus-hina
Copy link
Owner

eslint/eslint#12117

fetus-hina added a commit that referenced this issue Aug 19, 2019
if update it to v6.2.0, following code doesn't pass ESLint

```js
const list = ['a', 'b', 'c'];
for (const i in list) { // <- no-unused-vars "error 'i' is defined but never used"
  console.log(i);       // <- WE USE IT IN THIS LINE!!!!!!
}
```

See:
  https://twitter.com/fetus_hina/status/1163416507138768896
  https://twitter.com/fetus_hina/status/1163417546676039681
  https://twitter.com/fetus_hina/status/1163421886543323136
  #550
  eslint/eslint#12117
  babel/babel-eslint#791
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 20, 2019

  • The dependency eslint was updated from 6.1.0 to 6.2.1.

Your tests are still failing with this version. Compare changes

Release Notes for v6.2.1
  • 8c021b5 Upgrade: eslint-utils 1.4.2 (#12131) (Toru Nagashima)
  • e82388b Sponsors: Sync README with website (ESLint Jenkins)
  • 4aeeeed Docs: update docs for ecmaVersion 2020 (#12120) (silverwind)
  • 6886148 Docs: Add duplicate keys limitation to accessor-pairs (#12124) (Milos Djermanovic)
Commits

The new version differs by 6 commits.

  • 9cadb59 6.2.1
  • 22b7802 Build: changelog update for 6.2.1
  • 8c021b5 Upgrade: eslint-utils 1.4.2 (#12131)
  • e82388b Sponsors: Sync README with website
  • 4aeeeed Docs: update docs for ecmaVersion 2020 (#12120)
  • 6886148 Docs: Add duplicate keys limitation to accessor-pairs (#12124)

See the full diff

fetus-hina added a commit that referenced this issue Aug 26, 2019
related to:
  - #550
  - commit eed0d60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant