Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add python3.13 compatibility and code coverage checks #651

Merged
merged 17 commits into from
Mar 11, 2025
Merged

feat(core): add python3.13 compatibility and code coverage checks #651

merged 17 commits into from
Mar 11, 2025

Conversation

Archento
Copy link
Member

Proposed Changes

This PR adds Python3.13 compatibility and code coverage checks for our CI tests to increase overall code quality.

Linked Issues

closes: #495

Types of changes

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@Archento Archento enabled auto-merge (squash) March 11, 2025 16:31
jrriehl
jrriehl reviewed Mar 11, 2025
View reviewed changes
jrriehl
jrriehl reviewed Mar 11, 2025
View reviewed changes
@Archento @jrriehl
Update README.md
0d2a74b 
Co-authored-by: James Riehl <33920192+jrriehl@users.noreply.github.com>
@Archento @jrriehl
Update README.md
48620f4 
Co-authored-by: James Riehl <33920192+jrriehl@users.noreply.github.com>
jrriehl
jrriehl reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor changes to the README.

@Archento Archento merged commit 7630bf9 into main Mar 11, 2025
9 checks passed
@Archento Archento deleted the feat/python3-13-compat-and-more branch March 11, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrriehl jrriehl jrriehl approved these changes

@lrahmani lrahmani Awaiting requested review from lrahmani lrahmani is a code owner

@qati qati Awaiting requested review from qati qati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare Python3.13 compatibility
2 participants
@Archento @jrriehl