Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 3 is now a permeation barrier model #30

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

RemDelaporteMathurin
Copy link
Collaborator

@jhdark I have completely modified task 3.

I kept the multi-material aspect of it but applied it to a real world example: permeation barriers.

Let me know what you think please

@jhdark
Copy link
Collaborator

jhdark commented Jul 3, 2023

This is looking great, and much more appropriate considering the feedback from the survey.

A few comments:

  • I feel towards the beginning the law of chemical potential could be displayed/described
  • In the materials section, perhaps the difference between sieverts and henry could be specified and in which case you would use them for people who arn't aware of them

@RemDelaporteMathurin RemDelaporteMathurin merged commit 43435da into main Jul 3, 2023
1 check passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the task3-improvement branch July 3, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants