add cache control header option #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
force-pushed
the
add_cache_headers
branch
from
029a338
to
8789a81
Compare
itowlson
reviewed
Jun 25, 2023
src/bartholomew.rs
Outdated
| .head | ||
| .cache_control | ||
| .clone() | ||
| .unwrap_or_else(|| DEFAULT_CACHE_CONTROL.to_owned()); |
There was a problem hiding this comment.
This is a change in behaviour, I think, defaulting to instructing no-cache instead of not caring? Is that intentional? If so, maybe leave a comment on why?
Should users have a way to omit the cache-control header instead of using no-cache?
There was a problem hiding this comment.
Good point. I will just make the adding of the header optional.
|
@itowlson I will add docs to |
|
Ah, of course, the docs are in a separate repo, as I perfectly well knew. I feebly plead Monday. |
karthik2804
force-pushed
the
add_cache_headers
branch
from
8789a81
to
4ef4ccc
Compare
itowlson
approved these changes
Jun 25, 2023
src/content.rs
Outdated
| @@ -50,6 +50,11 @@ pub struct Head { | |||
| /// | |||
| /// This may result in HTTP headers being altered. | |||
| pub content_type: Option<String>, | |||
| /// Cache Control header override. | |||
| /// | |||
| /// The default is to send no cachce control headers. This should only be | |||
There was a problem hiding this comment.
Suggested change
| /// The default is to send no cachce control headers. This should only be | |
| /// The default is to send no cache control headers. This should only be |
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
add_cache_headers
branch
from
4ef4ccc
to
23ca5e0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional header field to allow the browser to cache the responses.