Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spin.toml): update redirected contributing route #158

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

vdice
Copy link
Member

@vdice vdice commented Feb 8, 2023

No description provided.

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice
Copy link
Member Author

vdice commented Feb 8, 2023

Actually, @tpmccallum, I'm wondering if the change should be in the developer repo to update the endpoint to developer.fermyon.com/bartholomew/contributing (and thus close this PR) -- thoughts?

@vdice vdice requested a review from tpmccallum February 8, 2023 15:23
@karthik2804
Copy link
Contributor

I think this route might change based on how common docs are organized in developer.

@vdice
Copy link
Member Author

vdice commented Feb 8, 2023

@karthik2804 we've updated spin recently with similar: fermyon/spin#1123

I'd actually like to see the endpoints be bartholomew/contributing and spin/contributing, but defer to you and @tpmccallum to make the change -- and we can sync up the changes here in tandem.

In the meantime, I'd say we get this in to match what currently exists. WDYT?

@karthik2804
Copy link
Contributor

Oh actually you are correct, contributing to docs is the one that is going to be common I assume, not the code itself,

@vdice vdice merged commit 61f0ac8 into fermyon:main Feb 8, 2023
@vdice vdice deleted the chore/update-contrib-redirect branch February 8, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants