-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seperate server functionality into server feature #130
Conversation
Signed-off-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com>
@karthik2804 Thanks for figuring out the real cause and for fixing it! It looks good to me, though probably needs someone more knowledgeable than me to provide proper feedback. @tpmccallum Could you give this a go please? I'm thinking exercise the Windows client but also re-exercise the Linux or Mac client, and the server, to make sure this hasn't affected them. Thanks! |
Thanks @itowlson, thanks, I will test Linux, macOS and Windows today and respond in here. |
Testing building Bartholomew Server and Bartholomew CLI using the new code in this PR. Housekeeping ``bash
Bartholomew ServermacOS make build
// ...
Finished release [optimized] target(s) in 1m 00s Windows make build
// ...
Finished release [optimized] target(s) in 1m 13s Linux make build
// ...
Finished release [optimized] target(s) in 52.92s Bartholomew CLImacOS make bart
cargo build --release --manifest-path=bart/Cargo.toml
// ...
Finished release [optimized] target(s) in 40.75s Windows make bart
cargo build --release --manifest-path=bart/Cargo.toml
Finished release [optimized] target(s) in 1m 01s Linux make bart
cargo build --release --manifest-path=bart/Cargo.toml
// ...
Finished release [optimized] target(s) in 1m 00s LGTM |
I also used |
@tpmccallum Perfect, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Split functionality into server feature as per #129. The actual issue arose due to
handlebars-sprig
now having a dependency onspin-sdk
to enable the tweet embeds functionality. This has now been fixed.Tested compiling on both windows 10 VM as well as cross-compiling using the
x86_64-pc-windows-gnu
andx86_64-pc-windows-msvc
target.Signed-off-by: Karthik Ganeshram karthik.ganeshram@fermyon.com