-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify README and transfer content, also new content Spin/Bart using website template #110
Conversation
…g website template Signed-off-by: tpmccallum <mistermac2008@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a single "bug" around the bartholomew spin template which should be fixed. Everything else is just feedback and not blocking.
Awesome feedback, thank you @mikkelhegn The |
There's no |
(There is of course no reason we couldn't create a Spin template for a Bartholomew web site. But this isn't that.) |
Thank you Ivan @itowlson |
People creating sites would not clone the template I think - they would use the template to create a new repo. (obviously if the article is about working on the template itself then yes, fork and clone) |
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Hi @mikkelhegn and @itowlson |
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Please note, that those changes have been actioned in the last few commits. |
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the .DS_Store files are now checked-in, in a few places?
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Changes I asked for are done, but don't feel confident to approve
Thanks @radu-matei glad to wrap this one up. |
This is a PR which is the beginning of creating a single source of truth for the Bartholomew docs.
Essentially, remove content from the
readme.md
file and place that content in the official docs (in the relevant spots/files).Also updated the documentation to reflect that Spin exclusively creates a new site (and can do so using a template) and that Bart will no longer be performing this sort of task.
The initiative for this change
The conversation about the idea to simplify the README.md can be found here.
The tests in relation to this change
Preview
spin up -e "PREVIEW_MODE=1"
Bart check
bart check
Signed-off-by: tpmccallum mistermac2008@gmail.com